I live in Indiana, so there's (generally) no shortage of rain. The golf courses in this town still water the entire grass of the course every day. Even if it rained the day before. Even if it's raining right then and there. There aren't water shortages here, but what a waste.
Most courses use man made ponds as both hazards and as retention ponds so they can use that rain water.
You know what uses three times the amount of water per acre? Corn. And almonds use about ten times more water than corn. And people have only just started caring about lawns, that use two orders of magnitude more water, fertilizer, and land than golf courses.
Golf courses really aren't that bad from an ecological point of view when compared acre per acre to other large man made structures. They're generally pretty small when compared to other large landscaping projects at 30-80 acres. The issue is when a city has like twenty courses just for the purpose of driving up housing prices.
Would that land be better as a park? Probably, but this is the US, someone would see an unprofitable "empty" plot of land and throw million dollar houses on it.
You get nothing of value from golf. I don't play either so neither do I, but this very much comes off as "stop liking things I don't like" rather than something that is actually important.
At least in the southwestern US most of them are a moot point. The vast majority of golf courses are being redeveloped because the course went bankrupt over the last decade or so. A few are managing to stick around, but I wouldn't be surprised if over 90% of the historical courses are gone in the next few years.
Most of the US corn crop goes to animal feed, so no you don't get food from it. At least not directly. If you totaled up all of the land used by golf courses, you'd be at .1% of just the amount of land used for animal feed. And about 1% of the land used by home lawns.
They're not that bad, there are much worse enemies than golf courses in general. Again, courses that are in the middle of a city that do nothing but increase property value are terrible, but most are perfectly fine and use way less water than you think.
Well I admit I haven't seen the entirety of those courses, but based on what I've seen, and considering they're surrounded by either businesses, houses or, in one case, a hospital, I don't know where those retention ponds would be. The hazards they have absolutely wouldn't be big enough to cover the amount of water I see sprayed on them.
I have never seen a golf course next to a hospital... Maybe it's regional, but near me, most courses have many made ponds that hold rain water and you can smell the pond water when the sprinklers come on. The ponds can hold several Olympic swimming pools worth of water.