A mondegreen (/ˈmɒndɪˌɡriːn/ ⓘ) is a mishearing or misinterpretation of a phrase in a way that gives it a new meaning.[1] Mondegreens are most often created by a person listening to a poem or a song; the listener, being unable to hear a lyric clearly, substitutes words that sound similar and make some kind of sense.[2][3] The American writer Sylvia Wright coined the term in 1954, recalling a childhood memory of her mother reading the Scottish ballad "The Bonnie Earl o' Moray", and mishearing the words "laid him on the green" as "Lady Mondegreen".
A malapropism (/ˈmæləprɒpɪzəm/; also called a malaprop, acyrologia, or Dogberryism) is the incorrect use of a word in place of a word with a similar sound, either unintentionally or for comedic effect, resulting in a nonsensical, often humorous utterance. An example is the statement attributed to baseball player Yogi Berra, regarding switch hitters, "He hits from both sides of the plate. He's amphibious",[1] with the accidental use of amphibious rather than the intended ambidextrous. Malapropisms often occur as errors in natural speech and are sometimes the subject of media attention, especially when made by politicians or other prominent individuals.
Though this is not for idiomatic phrases, there's also misnomer, for when something is named in a misleading or inappropriate manner.
Though, different dictionaries seem to give different scope to what can and cannot be considered a misnomer, and others place different emphasis on precisely how the name is wrong qualifies it as a misnomer.
Cambridge lists 'dry cleaning' as an example, a process that involves liquid and is thus antithetical.
The focus is on something being named such that the obvious, plain reading of it implies the precise opposite.
Merriam Webster lists that its a misnomer to call a farmer a peasant, which is not antithetical but more along the lines of being rude, out of date.
Their conception of it is fairly broad: any name that is inaccurate for basically any reason, or even just a word that has offensive connotations due to inaccuracy.
Dictionary.com uses the examples of Chinese Checkers, a funny bone, and hay fever.
They focus the definition on the factual/historical inaccuracy of the term:
Chinese Checkers did not originate in China, a funny bone is actually a nerve, not a bone, and hay fever is not caused by hay, nor is it a fever.
Arguably, a mechanic who is literally performing maintenance on exceptionally mechanically dense and complex parts of a rocket, say the rocket engine plumbing or wiring harnesses... is figuratively performing rocket surgery.
Now, that one does have its place. I either it in an ironic sense that you dont need multiple degrees to do something. The flip side is that the people we send to space tend to be the most qualified people in multiple fields, a medical surgeon with a stem degree does not sound too far outside the realm of reason.
I like, "get two birds stoned with one bush" as some bastard amalgamation of "kill two birds with one stone" and "a bird in the hand is worth two in the bush"
I do it in danish, but we have the idiom here too. I'll often make up a new one following the not the x y in the z template.
E.g. Not the loudest spoon in the forest.
"The blood of the covenant is thicker than the water of the womb." Meaning contracts, friendships, and keeping promises should take priority over family loyalty.
Now changed to "Blood is thicker than water" and means the exact opposite of the original.
When referring to a difficult task: "That's a tough road to hold", or "a tough road to hoe", or "a tough road to [travel on]" or "a tough road to... [trails off awkwardly...]", or just "a tough road".
It's a tough row to hoe.
It's an agricultural metaphor. The row is a line of dirt in a field where you plant seeds. You use a hoe to dig the lines, remove weeds, and create little holes where you drop the seeds. Hoeing may be difficult if the soil is too hard or too full of rocks and weeds. Such a row would be a tough one to hoe.
So, lots of examples, but not much on your question about terminology. In looking around a bit, I couldn't find a single specific term for a malapropism that "sticks," but you could fairly describe it as a form semantic drift driven by catachresis, thought the latter seems more common in literary criticism or philosophy than in linguistics.
Even then, I can't quite find a single Linguistics term for this phenomenon, where it becomes a thing of its own or even replaces the original. 'Eggcorn' and 'Malaphor' seem to be pretty decent casual terms.